Skip to content

Update Cassandra TTL behavior #9371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Update Cassandra TTL behavior #9371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Cassandra/Orleans.Clustering.Cassandra/OrleansQueries.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,9 +197,10 @@ UPDATE membership
IF
version = :expected_version;
""",
// This is ignored because we're creating a LWT
MembershipWriteConsistencyLevel);

return _updateIAmAliveWithTtlPreparedStatement.Bind(new
BoundStatement updateIAmAliveTimeWithTtL = _updateIAmAliveWithTtlPreparedStatement.Bind(new
{
partition_key = clusterIdentifier,
// The same version still needs to be written, to update its cell-level TTL
Expand All @@ -217,6 +218,10 @@ UPDATE membership
// But we still check that the version was the same during the update so we don't stomp on another update
expected_version = existingVersion.Version,
});

// To improve performance, we allow IAmAlive updates to be LocalSerial
updateIAmAliveTimeWithTtL.SetSerialConsistencyLevel(ConsistencyLevel.LocalSerial);
return updateIAmAliveTimeWithTtL;
}

public async ValueTask<IStatement> DeleteMembershipEntry(string clusterIdentifier, MembershipEntry membershipEntry)
Expand Down
Loading