Align AsyncEnumerable cancellation semantics to .NET expectations #9359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenBond
force-pushed
the
shutdown/fix-asyncenumerable-cancellation-behavior
branch
from
2d21b3b to
52822ae
Compare
ReubenBond
force-pushed
the
shutdown/fix-asyncenumerable-cancellation-behavior
branch
from
f4cc48d to
3de1a53
Compare
ReubenBond
deleted the
shutdown/fix-asyncenumerable-cancellation-behavior
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The norm in .NET is that if cancellation is triggered while awaiting enumeration of an
IAsyncEnumerable<T>, that will result in an exception being thrown.The current behavior in the
AsyncEnumerable<T>class is that it ends enumeration instead (as though there were no more items). This is more graceful and results in less exceptions being thrown during shutdown, but it's not the normal or expected behavior.This PR aligns
AsyncEnumerable<T>to the normal .NET behavior, causing cancellation to throw instead or ending enumeration without an exception.Microsoft Reviewers: Open in CodeFlow