Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Orleans.Serialization/Serializers/CodecProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ private IFieldCodec CreateCodecInstance(Type fieldType, Type searchType)
}
else if (searchType.BaseType is object
&& CreateCodecInstance(
fieldType,
fieldType.BaseType,
searchType.BaseType switch
{
{ IsConstructedGenericType: true } => searchType.BaseType.GetGenericTypeDefinition(),
Expand Down
30 changes: 30 additions & 0 deletions test/Orleans.Serialization.UnitTests/GenericBaseClassTest.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
using Microsoft.Extensions.DependencyInjection;
using Xunit;

namespace Orleans.Serialization.UnitTests
{
[GenerateSerializer]
abstract class Base<T>;

class Derived : Base<int>;

[Trait("Category", "BVT")]
public class GenericBaseClassTest
{
private readonly ServiceProvider _services;
private readonly Serializer _serializer;
public GenericBaseClassTest()
{
_services = new ServiceCollection()
.AddSerializer()
.BuildServiceProvider();
_serializer = _services.GetRequiredService<Serializer>();
}

[Fact]
public void DerivedNoGeneric()
{
Assert.False(_serializer.CanSerialize(typeof(Derived)));
}
}
}
Loading