Skip to content

Randomize CorrelationId generation per host #9213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2024
Merged

Randomize CorrelationId generation per host #9213

merged 2 commits into from
Nov 5, 2024

Conversation

@ReubenBond
Copy link
Member

@ReubenBond ReubenBond commented Nov 1, 2024 •
edited by dotnet-policy-service bot
Loading

This PR introduces per-host randomization for message identifiers.
This serves two purposes:

  1. It makes it easier to search diagnostic logs for instances of a message, since the ids are practically unique.
  2. It allows us to use the message id in subsequent messages to a given grain. In particular, to implement cancellation support cheaply (see Support for .NET CancellationTokens #9127 by @koenbeuk)
Microsoft Reviewers: Open in CodeFlow

@benjaminpetit benjaminpetit merged commit 186e5f8 into dotnet:main Nov 5, 2024
16 checks passed
@ReubenBond ReubenBond deleted the fix/randomize-correlation-id-per-host branch November 5, 2024 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@benjaminpetit benjaminpetit benjaminpetit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReubenBond @benjaminpetit