-
Notifications
You must be signed in to change notification settings - Fork 2.1k
IConfiguration support for Azure Cosmos DB Clustering Provider
#9204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IConfiguration support for Azure Cosmos DB Clustering Provider
#9204
Conversation
|
@dotnet-policy-service agree |
|
Is this ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
|
@ReubenBond I believe it is, however I would want to run the pipelines again to ensure there aren't any hidden issues. |
bf98daf to
ff3874c
Compare
|
@OmnipotentOwl I rebased and am re-running workflows. Ideally, we should update the tests to use this new configuration mechanism |
|
@ReubenBond, I did some local testing with Aspire with the clustering configuration, and it looks to work mostly for the Cosmos DB emulator (next). I did have to adjust the assembly: RegisterProvider name property based on what I saw in Aspire, but if you feel like we shouldn't rename that or name it just 'Cosmos,' then we might need to do a shim in Aspire to handle that difference. I am going to see if I can run it tomorrow against a real Cosmos DB instance and if that looks good I may have another PR here shortly for the storage provider. |
Added a `using` directive for `System.Runtime.CompilerServices` and
an assembly attribute `[assembly: InternalsVisibleTo("Tester.AzureUtils")]`
to make internal types visible to the `Tester.AzureUtils` assembly.
Introduce CosmosClusteringProviderBuilder class implementing IProviderBuilder<ISiloBuilder> and IProviderBuilder<IClientBuilder> interfaces. Register the class as a provider for both "Silo" and "Client" roles. Implement Configure methods to set up Cosmos DB clustering options and client configuration. Import necessary namespaces to support the new functionality. This adds support for using the Cosmos DB Clustering Provider from Orleans IConfiguration setup.
Replaced "Cosmos" with "AzureCosmosDB" in the assembly registrations for the `CosmosClusteringProviderBuilder` for both "Silo" and "Client" configurations to better reflect the configuration values used by Aspire.
038fd6a to
05ae7af
Compare
|
LGTM - I tested with Aspire, using this config: var builder = DistributedApplication.CreateBuilder(args);
var cosmosDb = builder.AddAzureCosmosDB("cosmos-clustering").RunAsEmulator();
var db = cosmosDb.AddCosmosDatabase("Orleans").AddContainer("OrleansCluster", "/ClusterId");
var orleans = builder.AddOrleans("cluster")
.WithClustering(cosmosDb);
builder.AddProject<DashboardToy_Frontend>("frontend")
.WithReference(orleans)
.WithReference(db)
.WaitFor(db)
.WaitFor(cosmosDb)
.WithReplicas(5);
builder.Build().Run(); |
|
It did not work with the vNext emulator for me - seemingly due to this issue, based on the error message: Azure/azure-cosmos-db-emulator-docker#170 |
IConfiguration support for Azure Cosmos DB Clustering Provider
PR Classification
New feature: Introduce support for Cosmos DB clustering provider for Orleans via Microsoft.Extensions.Configuration.
PR Summary
This pull request supports the Cosmos DB clustering provider for Orleans to be configured via Microsoft.Extensions.Configuration, enabling clustering configurations for both Silo and Client roles.
CosmosClusteringProviderBuilderclass and registered it as a provider.CosmosClusteringOptionsand a validator class.[assembly: InternalsVisibleTo("Tester.AzureUtils")]attribute.Microsoft Reviewers: Open in CodeFlow