Migrate AdoGrainStorage to the new grain serializer - #8081
Merged
Merged
Conversation
Contributor
Author
|
There is some errors in some SQL scripts, but test are green... I will open another PR to fix the tests, do not merge this one yet |
benjaminpetit
force-pushed
the
serialization/ado
branch
from
October 27, 2022 18:14
3f8acad to
ff5be58
Compare
ReubenBond
force-pushed
the
serialization/ado
branch
from
October 31, 2022 18:13
0e7eefe to
f4c9c75
Compare
benjaminpetit
force-pushed
the
serialization/ado
branch
from
November 2, 2022 08:28
f4c9c75 to
1c5a184
Compare
Contributor
Author
|
Will close #8077 once merged |
benjaminpetit
added a commit
to benjaminpetit/orleans
that referenced
this pull request
Nov 2, 2022
benjaminpetit
added a commit
to benjaminpetit/orleans
that referenced
this pull request
Nov 2, 2022
ReubenBond
pushed a commit
to benjaminpetit/orleans
that referenced
this pull request
Nov 3, 2022
Contributor
|
@benjaminpetit does this mean that JSON is no longer an option? |
Contributor
|
@benjaminpetit we should also probably flatten the SQL scripts into one per ado engine |
Contributor
Author
It's still possible, it's even the default. You can configure the serializer you want in the option. |
Contributor
|
@ElanHasson We should do that that flattening. At the same go, remove the preprocessor directives in the code (haven't checked the PR). :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify
AdoGrainStorageand make the configuration experience similar to the other persistence provider, the serializer forAdoGrainStoragewill be configured usingAdoNetGrainStorageOptions.GrainStorageSerializerMicrosoft Reviewers: Open in CodeFlow