Repository navigation
Add SlowConsumingPressureMonitor #2873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
378d76b
add SlowConsumingPressureMonitor
xiazen 300db7c
add one option to configure EventHubQeueuCache with the SlowConsuming…
xiazen 9372367
add configure option through EventHubProviderSettings
xiazen 6908027
PR feedback and add testing
xiazen 6562a19
PR feedback
xiazen 96f7de0
PR feedback
xiazen a728bca
make slowpressuremonitor more conservative
xiazen bfcc1fb
make SlowConsumerMonitor.DefaultWindowSize public
xiazen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
...iceBus/Providers/Streams/EventHub/CachePressureMonitors/AggregatedCachePressureMonitor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Orleans.ServiceBus.Providers | ||
| { | ||
| /// <summary> | ||
| /// Aggregated cache pressure monitor | ||
| /// </summary> | ||
| public class AggregatedCachePressureMonitor : List<ICachePressureMonitor>, ICachePressureMonitor | ||
| { | ||
| /// <summary> | ||
| /// Record cache pressure to every monitor in this aggregated cache monitor group | ||
| /// </summary> | ||
| /// <param name="cachePressureContribution"></param> | ||
| public void RecordCachePressureContribution(double cachePressureContribution) | ||
| { | ||
| this.ForEach(monitor => | ||
| { | ||
| monitor.RecordCachePressureContribution(cachePressureContribution); | ||
| }); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Add one monitor to this aggregated cache monitor group | ||
| /// </summary> | ||
| /// <param name="monitor"></param> | ||
| public void AddCachePressureMonitor(ICachePressureMonitor monitor) | ||
| { | ||
| this.Add(monitor); | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// If any mornitor in this aggregated cache monitor group is under pressure, then return true | ||
| /// </summary> | ||
| /// <param name="utcNow"></param> | ||
| /// <returns></returns> | ||
| public bool IsUnderPressure(DateTime utcNow) | ||
| { | ||
| return this.Any(monitor => monitor.IsUnderPressure(utcNow)); | ||
| } | ||
| } | ||
| } |
93 changes: 93 additions & 0 deletions
93
...viceBus/Providers/Streams/EventHub/CachePressureMonitors/AveragingCachePressureMonitor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| using Orleans.Runtime; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Orleans.ServiceBus.Providers | ||
| { | ||
| /// <summary> | ||
| /// Cache pressure monitor whose back pressure algorithm is based on averaging pressure value | ||
| /// over all pressure contribution | ||
| /// </summary> | ||
| public class AveragingCachePressureMonitor : ICachePressureMonitor | ||
| { | ||
| /// <summary> | ||
| /// Default flow control threshold | ||
| /// </summary> | ||
| public static readonly double DefaultThreshold = 1 / 3; | ||
| private static readonly TimeSpan checkPeriod = TimeSpan.FromSeconds(2); | ||
| private readonly Logger logger; | ||
|
|
||
| private double accumulatedCachePressure; | ||
| private double cachePressureContributionCount; | ||
| private DateTime nextCheckedTime; | ||
| private bool isUnderPressure; | ||
| private double flowControlThreshold; | ||
|
|
||
| /// <summary> | ||
| /// Constructor | ||
| /// </summary> | ||
| /// <param name="logger"></param> | ||
| public AveragingCachePressureMonitor(Logger logger) | ||
| :this(DefaultThreshold, logger) | ||
| { } | ||
|
|
||
| /// <summary> | ||
| /// Contructor | ||
| /// </summary> | ||
| /// <param name="flowControlThreshold"></param> | ||
| /// <param name="logger"></param> | ||
| public AveragingCachePressureMonitor(double flowControlThreshold, Logger logger) | ||
| { | ||
| this.flowControlThreshold = flowControlThreshold; | ||
| this.logger = logger.GetSubLogger(this.GetType().Name); | ||
| nextCheckedTime = DateTime.MinValue; | ||
| isUnderPressure = false; | ||
| } | ||
|
|
||
| public void RecordCachePressureContribution(double cachePressureContribution) | ||
| { | ||
| // Weight unhealthy contributions thrice as much as healthy ones. | ||
| // This is a crude compensation for the fact that healthy consumers wil consume more often than unhealthy ones. | ||
| double weight = cachePressureContribution < flowControlThreshold ? 1.0 : 3.0; | ||
| accumulatedCachePressure += cachePressureContribution * weight; | ||
| cachePressureContributionCount += weight; | ||
| } | ||
|
|
||
| public bool IsUnderPressure(DateTime utcNow) | ||
| { | ||
| if (nextCheckedTime < utcNow) | ||
| { | ||
| CalculatePressure(); | ||
| nextCheckedTime = utcNow + checkPeriod; | ||
| } | ||
| return isUnderPressure; | ||
| } | ||
|
|
||
| private void CalculatePressure() | ||
| { | ||
| // if we don't have any contributions, don't change status | ||
| if (cachePressureContributionCount < 0.5) | ||
| { | ||
| // after 5 checks with no contributions, check anyway | ||
| cachePressureContributionCount += 0.1; | ||
| return; | ||
| } | ||
|
|
||
| double pressure = accumulatedCachePressure / cachePressureContributionCount; | ||
| bool wasUnderPressure = isUnderPressure; | ||
| isUnderPressure = pressure > flowControlThreshold; | ||
| // If we changed state, log | ||
| if (isUnderPressure != wasUnderPressure) | ||
| { | ||
| logger.Info(isUnderPressure | ||
| ? $"Ingesting messages too fast. Throttling message reading. AccumulatedCachePressure: {accumulatedCachePressure}, Contributions: {cachePressureContributionCount}, AverageCachePressure: {pressure}, Threshold: {flowControlThreshold}" | ||
| : $"Message ingestion is healthy. AccumulatedCachePressure: {accumulatedCachePressure}, Contributions: {cachePressureContributionCount}, AverageCachePressure: {pressure}, Threshold: {flowControlThreshold}"); | ||
| } | ||
| cachePressureContributionCount = 0.0; | ||
| accumulatedCachePressure = 0.0; | ||
| } | ||
| } | ||
| } | ||
28 changes: 28 additions & 0 deletions
28
...leansServiceBus/Providers/Streams/EventHub/CachePressureMonitors/ICachePressureMonitor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Orleans.ServiceBus.Providers | ||
| { | ||
| /// <summary> | ||
| /// Cache pressure monitor records pressure contribution to the cache, and determine if the cache is under pressure based on its | ||
| /// back pressure algorithm | ||
| /// </summary> | ||
| public interface ICachePressureMonitor | ||
| { | ||
| /// <summary> | ||
| /// Record cache pressure contribution to the monitor | ||
| /// </summary> | ||
| /// <param name="cachePressureContribution"></param> | ||
| void RecordCachePressureContribution(double cachePressureContribution); | ||
|
|
||
| /// <summary> | ||
| /// Determine if the monitor is under pressure | ||
| /// </summary> | ||
| /// <param name="utcNow"></param> | ||
| /// <returns></returns> | ||
| bool IsUnderPressure(DateTime utcNow); | ||
| } | ||
| } |
104 changes: 104 additions & 0 deletions
104
...rviceBus/Providers/Streams/EventHub/CachePressureMonitors/SlowConsumingPressureMonitor.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| using Orleans.Runtime; | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Orleans.ServiceBus.Providers | ||
| { | ||
| /// <summary> | ||
| /// Pressure monitor which is in favor of the slow consumer in the cache | ||
| /// </summary> | ||
| public class SlowConsumingPressureMonitor : ICachePressureMonitor | ||
| { | ||
| private static TimeSpan DefaultPressureWindowSize = TimeSpan.FromMinutes(1); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Defaults should probably be public, so users can specify them in configurations if they want to be explicit. |
||
| private const double DefaultFlowControlThreshold = 0.5; | ||
|
|
||
| /// <summary> | ||
| /// PressureWindowSize | ||
| /// </summary> | ||
| public TimeSpan PressureWindowSize { get; set; } | ||
| /// <summary> | ||
| /// FlowControlThreshold | ||
| /// </summary> | ||
| public double FlowControlThreshold { get; set; } | ||
|
|
||
| private readonly Logger logger; | ||
| private double biggestPressureInCurrentPeriod; | ||
| private DateTime nextCheckedTime; | ||
| private bool isUnderPressure; | ||
|
|
||
| /// <summary> | ||
| /// Constructor | ||
| /// </summary> | ||
| /// <param name="logger"></param> | ||
| public SlowConsumingPressureMonitor(Logger logger) | ||
| : this(DefaultFlowControlThreshold, DefaultPressureWindowSize, logger) | ||
| { } | ||
|
|
||
| /// <summary> | ||
| /// Constructor | ||
| /// </summary> | ||
| /// <param name="pressureWindowSize"></param> | ||
| /// <param name="logger"></param> | ||
| public SlowConsumingPressureMonitor(TimeSpan pressureWindowSize, Logger logger) | ||
| : this(DefaultFlowControlThreshold, pressureWindowSize, logger) | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Constructor | ||
| /// </summary> | ||
| /// <param name="flowControlThreshold"></param> | ||
| /// <param name="logger"></param> | ||
| public SlowConsumingPressureMonitor(double flowControlThreshold, Logger logger) | ||
| : this(flowControlThreshold, DefaultPressureWindowSize, logger) | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Constructor | ||
| /// </summary> | ||
| /// <param name="flowControlThreshold"></param> | ||
| /// <param name="pressureWindowSzie"></param> | ||
| /// <param name="logger"></param> | ||
| public SlowConsumingPressureMonitor(double flowControlThreshold, TimeSpan pressureWindowSzie, Logger logger) | ||
| { | ||
| this.FlowControlThreshold = flowControlThreshold; | ||
| this.logger = logger.GetSubLogger(this.GetType().Name); | ||
| this.nextCheckedTime = DateTime.MinValue; | ||
| this.biggestPressureInCurrentPeriod = 0; | ||
| this.isUnderPressure = false; | ||
| this.PressureWindowSize = pressureWindowSzie; | ||
| } | ||
|
|
||
| public void RecordCachePressureContribution(double cachePressureContribution) | ||
| { | ||
| if (cachePressureContribution > biggestPressureInCurrentPeriod) | ||
| biggestPressureInCurrentPeriod = cachePressureContribution; | ||
| } | ||
|
|
||
| public bool IsUnderPressure(DateTime utcNow) | ||
| { | ||
| //if any pressure contribution in current period is bigger than flowControlThreshold | ||
| //we see the cache is under pressure | ||
| bool underPressure = this.biggestPressureInCurrentPeriod > this.FlowControlThreshold; | ||
| if (this.isUnderPressure != underPressure) | ||
| { | ||
| this.isUnderPressure = underPressure; | ||
| logger.Info(this.isUnderPressure | ||
| ? $"Ingesting messages too fast. Throttling message reading. BiggestPressureInCurrentPeriod: {biggestPressureInCurrentPeriod}, Threshold: {FlowControlThreshold}" | ||
| : $"Message ingestion is healthy. BiggestPressureInCurrentPeriod: {biggestPressureInCurrentPeriod}, Threshold: {FlowControlThreshold}"); | ||
| } | ||
|
|
||
| if (nextCheckedTime < utcNow) | ||
| { | ||
| //at the end of each check period, reset biggestPressureInCurrentPeriod | ||
| this.nextCheckedTime = utcNow + this.PressureWindowSize; | ||
| this.biggestPressureInCurrentPeriod = 0; | ||
| } | ||
| return underPressure; | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the info level version of this log message should be in the aggregate pressure monitor, and the logging in the specific monitors should be verbose.
The reason for this is that a specific monitor may become healthy, but reading will still be off until all monitors are healthy. So having per monitor logging will make it very hard for users to decipher, from logs, if a queue should be reading or not. These details may be useful in verbose logging, as they would indicate what monitor is stopping reading, but this level of detail is less important, imo, than the overall flow control state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do . valid concern.