Skip to content

test: keep observer alive through callback completion in GrainObserverWithGenericMethods #11439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 1 commit into from
Oct 8, 2026
Merged

test: keep observer alive through callback completion in GrainObserverWithGenericMethods #11439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/Orleans.DefaultCluster.Tests/CodeGenTests/GeneratorGrainTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ public async Task GrainObserverWithGenericMethods()
var observer = this.GrainFactory.CreateObjectReference<IGrainObserverWithGenericMethods>(localObject);
await grain.SetValueOnObserver(observer, "ToastedEnchiladas");
Assert.Equal("ToastedEnchiladas", await localObject.ValueTask);

// Keep the observer strongly reachable until its callback completes. CreateObjectReference holds
// only a weak reference to the target, so a garbage collection that runs after the ValueTask getter
// above is read (and before SetValue is invoked) could otherwise collect localObject prematurely,
// leaving valueCompletion uncompleted and this test hanging indefinitely (see dotnet/orleans#11427).
GC.KeepAlive(localObject);
}

[Fact]
Expand Down
Loading