Skip to content

fix(streaming): bound NATS producer selection #11287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 2 commits into from
Sep 17, 2026
Merged

fix(streaming): bound NATS producer selection #11287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef7baa9
fix(streaming): bound NATS producer selection
ReubenBond Sep 8, 2026
4c12df0
test(streaming): cover NATS producer index boundaries
ReubenBond Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/Orleans.Streaming.NATS/Providers/NatsConnectionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public async Task EnqueueMessage(NatsStreamMessage message, CancellationToken ca

var subject = $"{this._providerName}.{ns}.{id}";

var context = this._producerNatsContexts[Math.Abs(id.GetHashCode()) % this._producerNatsContexts.Length];
var context = this._producerNatsContexts[GetProducerIndex(id.GetHashCode(), this._producerNatsContexts.Length)];

var ack = await context.TryPublishAsync(
subject,
Expand Down Expand Up @@ -192,6 +192,9 @@ public NatsStreamConsumer CreateConsumer(uint partition) =>
this._options.BatchSize,
this._natsClientOptions.SerializerRegistry.GetDeserializer<NatsStreamMessage>());

internal static int GetProducerIndex(int hashCode, int producerCount)
=> (int)((uint)hashCode % (uint)producerCount);

/// <summary>
/// Acknowledge messages on a subject in a NATS JetStream stream
/// </summary>
Expand Down
25 changes: 25 additions & 0 deletions test/Extensions/Orleans.Streaming.NATS.Tests/NatsOptionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,31 @@ public void DefaultStorageType_ShouldBeFile()
Assert.Equal(StreamConfigStorage.File, options.StorageType);
}

[Theory]
[InlineData(int.MinValue, 1, 0)]
[InlineData(int.MinValue, 3, 2)]
[InlineData(int.MinValue, 8, 0)]
[InlineData(int.MinValue, int.MaxValue, 1)]
[InlineData(-1, 1, 0)]
[InlineData(-1, 3, 0)]
[InlineData(-1, 8, 7)]
[InlineData(-1, int.MaxValue, 1)]
[InlineData(0, 1, 0)]
[InlineData(0, 3, 0)]
[InlineData(0, 8, 0)]
[InlineData(0, int.MaxValue, 0)]
[InlineData(int.MaxValue, 1, 0)]
[InlineData(int.MaxValue, 3, 1)]
[InlineData(int.MaxValue, 8, 7)]
[InlineData(int.MaxValue, int.MaxValue, 0)]
public void ProducerIndex_IsAlwaysWithinBounds(int hashCode, int producerCount, int expectedIndex)
{
var index = NatsConnectionManager.GetProducerIndex(hashCode, producerCount);

Assert.Equal(expectedIndex, index);
Assert.InRange(index, 0, producerCount - 1);
}

[Theory]
[InlineData(0)]
[InlineData(-1)]
Expand Down
Loading