test(azure): cover queue JSON validation

[ReubenBond]

Part of #10861.

The Azure Queue JSON adapter tests used legacy category traits, so the Azure Storage coverage partition selected none of them. This change adds first-class suite, provider, and area traits so the existing credential-free tests contribute to provider coverage, then covers unsupported envelope versions, malformed required fields and types, and invalid JSON.

Targeted coverage impact for AzureQueueJsonDataAdapter:

Scope	Before	After
Class line coverage	90.95%	93.97%
Class branch coverage	78.41%	86.36%
TryDeserializeCompactJson line coverage	87.50%	100%
TryDeserializeCompactJson branch coverage	62.50%	83.33%
GetRequiredProperty line coverage	66.67%	100%
GetRequiredProperty branch coverage	50%	100%

The canonical Azure Storage CI query now selects all 29 adapter test cases instead of zero. These tests run without credentials or Azurite.

Remaining #10861 scope includes DynamoDB mutation/configuration and reminder parsing, Azure table/blob/queue error paths, and focused Google, Redis, and Cassandra gaps.

Microsoft Reviewers: Open in CodeFlow

[Copilot]

Copilot review overview

Review tier: Lite
Findings: 1

New issues introduced by this change (1)

Severity	Finding
	test/​Extensions/​Orleans.Azure.Tests/​Streaming/​AzureQueueJsonDataAdapterTests.cs — This test class now has Suite/Provider/Area traits but no longer has the legacy Category traits…

What changed in this PR

Updates Azure Queue JSON adapter tests so they are correctly picked up by Azure provider coverage lanes and expands negative-path validation coverage for compact JSON envelopes.

Changes:

• Replaces legacy class-level TestCategory("AzureStorage")/TestCategory("Streaming") traits with first-class TestSuite/TestProvider/TestArea traits.
• Adds new BVT test cases covering unsupported compact envelope versions, malformed required fields/types, and invalid JSON parsing.

File	Description
test/​Extensions/​Orleans.Azure.Tests/​Streaming/​AzureQueueJsonDataAdapterTests.cs	Adds provider/suite/area traits and expands negative-path JSON envelope validation tests

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Copilot review overview

Review tier: Lite
Findings: 1 · 1

New issues introduced by this change (1)

Severity	Finding
	test/​Extensions/​Orleans.Azure.Tests/​Streaming/​AzureQueueJsonDataAdapterTests.cs — Asserting the full exception message makes the test brittle and currently this is the only…

Pre-existing issues (1)

Severity	Finding
	test/​Extensions/​Orleans.Azure.Tests/​Streaming/​AzureQueueJsonDataAdapterTests.cs — This test class now has Suite/Provider/Area traits but no longer has the legacy Category traits… View comment

Suppressed comments (2)

test/Extensions/Orleans.Azure.Tests/Streaming/AzureQueueJsonDataAdapterTests.cs:24

• This file now uses the new suite/provider/area traits, but it removed the legacy AzureStorage/Streaming TestCategory tags which are still used across Orleans.Azure.Tests for filtering (e.g., test/Extensions/Orleans.Azure.Tests/AzureClientOptionsTests.cs:6 and Streaming/AzureQueueAdapterTests.cs:17). Keeping those categories in addition to TestSuite/TestProvider/TestArea preserves existing workflows and aligns with the project’s established test-tagging pattern.

    [Collection(TestEnvironmentFixture.DefaultCollection)]
    [TestSuite("BVT")]
    [TestProvider("AzureStorage")]
    [TestArea("Streaming")]

test/Extensions/Orleans.Azure.Tests/Streaming/AzureQueueJsonDataAdapterTests.cs:225

• Same here: asserting the full exception message (including exact enum casing/article) makes these validation tests more fragile than necessary. Using Assert.Contains provides coverage of the intended branch while allowing the error text to be clarified later.

            var exception = Assert.Throws<InvalidDataException>(
                () => jsonAdapter.FromQueueMessage(message, sequenceId: 0));

            Assert.Equal(expectedMessage, exception.Message);
        }

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

Issues resolved since last review (2)

Severity	Finding
	test/​Extensions/​Orleans.Azure.Tests/​Streaming/​AzureQueueJsonDataAdapterTests.cs — Asserting the full exception message makes the test brittle and currently this is the only… View resolved comment
	test/​Extensions/​Orleans.Azure.Tests/​Streaming/​AzureQueueJsonDataAdapterTests.cs — This test class now has Suite/Provider/Area traits but no longer has the legacy Category traits… View resolved comment

[github-actions]

Code coverage

78.67% line coverage - 99,603 / 126,605 lines

Coverage details

• Source files: 1,662
• Scope: every CI test matrix job, including providers, CodeGen, .NET 8/10, Linux, Windows, and macOS
• Sources: maintained repository code under src/ loaded by the complete CI test scope
• Commit: 736820283b
• View the test run and merged coverage artifact
• View the coverage reporting run