fix(testing): prevent fatal errors from terminating test hosts - #10438
Merged
ReubenBond merged 1 commit intoAug 11, 2026
Merged
Conversation
This was referenced Aug 11, 2026
TransactionWillRecoverAfterRandomSiloGracefulShutdown can observe no failure after silo death
#10418
Closed
Avoid treating a local dead membership row as fatal during graceful shutdown, isolate fatal errors to the affected test silo, stabilize liveness convergence, and replace the fake-time FailFast watchdog with an ordinary test timeout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8c700cc1-8a6e-459a-ae18-76b40d595ff7
ReubenBond
force-pushed
the
reubenbond-fix-liveness-test-failfast
branch
from
August 11, 2026 06:04
741753c to
00b52c9
Compare
This was referenced Aug 28, 2026
Merged
Merged
This was referenced Sep 4, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10409.
A graceful silo shutdown can publish the local membership row as
DeadbeforeMembershipTableManager.CurrentStatusis updated. A concurrent refresh then treats the expected shutdown transition as remote eviction and invokes the production fatal handler, terminating the entire shared test process.This change suppresses fatal handling when the silo lifecycle is already stopping, adds explicit membership convergence barriers to the liveness test, and replaces the production fatal handler in
Orleans.TestingHostso unexpected fatal errors stop only the affected silo. It also removes the remaining test-onlyEnvironment.FailFastwatchdog in fake-time tests in favor of an ordinary asynchronous timeout.Microsoft Reviewers: Open in CodeFlow