Skip to content

fix(runtime): unregister shutdown activations from directory #10206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ReubenBond merged 1 commit into from
Jun 11, 2026
Merged

fix(runtime): unregister shutdown activations from directory #10206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Orleans.Runtime/Catalog/ActivationData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2001,9 +2001,8 @@ private async Task FinishDeactivating(Command.Deactivate deactivateCommand, Canc

// If the instance is being deactivated due to a directory failure, we should not unregister it.
var isDirectoryFailure = DeactivationReason.ReasonCode is DeactivationReasonCode.DirectoryFailure;
var isShuttingDown = DeactivationReason.ReasonCode is DeactivationReasonCode.ShuttingDown;

if (!migrating && IsUsingGrainDirectory && !cancellationToken.IsCancellationRequested && !isDirectoryFailure && !isShuttingDown)
if (!migrating && IsUsingGrainDirectory && !cancellationToken.IsCancellationRequested && !isDirectoryFailure)
{
// Unregister from directory.
// If the grain was migrated, the new activation will perform a check-and-set on the registration itself.
Expand Down
Loading