fix(reminders): allow grains to update reminders during shutdown#10155
Merged
ReubenBond merged 2 commits intoMay 30, 2026
Merged
Conversation
ReubenBond
changed the title
Split reminder service shutdown so the Active stop only prevents new reminder delivery and drains in-flight callbacks. Defer full reminder service and table shutdown until RuntimeGrainServices stops, and let stopped-stage register/unregister operations proceed without logging or throwing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
fix-reminder-shutdown-storage-updates
branch
from
6bb8de9 to
4935d79
Compare
This was referenced Jun 14, 2026
This was referenced Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The active-stage reminder shutdown currently stops the local reminder service completely, so reminder register/unregister calls during later shutdown cleanup can fail with \ReminderService has been stopped.\n\nThis changes reminder shutdown so the Active stop only disables new reminder delivery and drains in-flight callbacks. Full service, timer, refresh-loop, and table shutdown is deferred until RuntimeGrainServices stops. Register/unregister operations are allowed to continue after the service is stopped without logging or throwing, relying on reminder table ETags for concurrency safety.
Microsoft Reviewers: Open in CodeFlow