Bound retries after directory activation failures#10094
Merged
ReubenBond merged 1 commit intoMay 12, 2026
Conversation
927de81 to
e6e3448
Compare
Remove the transient deactivation retry path used for directory activation failures. Forwarded messages now keep their existing ForwardCount value, so the normal MaxForwardCount budget bounds repeated directory-failure activation loops. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
e6e3448 to
f47c7bf
Compare
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When activation registration fails in the grain directory, queued-message rerouting could repeatedly forward the same message. The old transient deactivation retry path refunded
ForwardCount, so persistent directory activation failures could bypass the normalMaxForwardCountguard.Solution
Remove the transient deactivation retry helper and the
ForwardCountrefund branch at the reroute call site. Directory-failure reroutes now keep the message's existing forwarding count, so the defaultMaxForwardCountof 2 is enough to reject repeated activation loops.This keeps the existing forwarding budget as the only retry guard instead of adding a separate directory-failure retry budget.
Notes
No merge dependency. This is independent of #10095, which only avoids unnecessary same-silo cache invalidation headers.