-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adjust tests with terminal logger enabled #9995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ating TestEnvironment to avoid affecting the tests
ladipro
reviewed
Apr 12, 2024
ladipro
approved these changes
Apr 15, 2024
YuliiaKovalova
approved these changes
Apr 16, 2024
This was referenced Jul 28, 2025
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
This was referenced Aug 15, 2025
Open
This was referenced Aug 26, 2025
This was referenced Oct 15, 2025
Closed
Open
This was referenced Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9796
Context
With terminal logger enabled by
SET MSBUILDLIVELOGGER=auto, current tests has the following problems.Messageis ignored by terminal logger currently and this causes tests depending on the message fail. Though Some way to opt specific messages into printing in TerminalLogger #9667 could get messages ptinted in terminal logger, it is a way to opt. To make messages output in console logger and terminal logger both, we need the workaround for printing messages in terminal logger. Affected tests: Microsoft.Build.Engine.UnitTests.MSBuildServer_Tests.MSBUILDLIVELOGGER/MSBUILDTERMINALLOGGERaffects tests for these two environment variables. Affected tests: Microsoft.Build.UnitTests.TerminalLoggerConfiguration_Tests.TerminalLoggerOnByEnv.msbuild/src/MSBuild/XMake.cs
Lines 2854 to 2855 in bb7846e
In addition, cleaning up created TestEnvironment should revert variants in reverse order.
Changes Made
Message, use the workaround adding --interactive for terminal logger to make messages output in console logger and terminal logger both.Testing
Run existing tests locally with setting the environment variable. Also verified in CI through #9957.
Notes