-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Include Microsoft.Common.Test.targets in Arm64 #9984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @dfederm, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
rainersigwald
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine and is what I did for other arches in #9547. I think we should consider changing the import to be $(MSBuildToolsPath32) but let's take this for now.
|
/backport to vs17.10 |
|
Started backporting to vs17.10: https://github.com/dotnet/msbuild/actions/runs/8711422953 |
This file is missing, leading to errors in the Arm64 flavor of VS
See: https://developercommunity.visualstudio.com/t/Arm64-Unable-to-use-MicrosoftBuildRu/10632924?ref=native&refTime=1712530347328&refUserId=ba1eecbf-9f1b-431b-ba02-0503abd8762c