Skip to content

Conversation

@JanKrivanek
Copy link
Member

Fixes #9578 (comment)

Context

Forwarding logger might be configured to forward messages of particular importance regardless of the verbosity level of said logger.
GetMinimumMessageImportance should properly reflect that

Testing

Manual testing with the repro case (building msbuild with terminal logger)

@JanKrivanek JanKrivanek requested a review from ladipro January 16, 2024 20:02
Copy link
Member

@ladipro ladipro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Should the code change be reflected in the GetMinimumMessageImportance method comment?

@JanKrivanek JanKrivanek merged commit f9b862a into dotnet:main Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants