Skip to content

Stop touching GenerateBindingRedirects output #9338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Oct 19, 2023
Merged

Stop touching GenerateBindingRedirects output #9338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Tasks.UnitTests/GenerateBindingRedirects_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,8 @@ public void AppConfigFileNotSavedWhenIdentical()
redirectResults2.TargetAppConfigContent.ShouldContain("<assemblyIdentity name=\"System\" publicKeyToken=\"b77a5c561934e089\" culture=\"neutral\" />");
redirectResults2.TargetAppConfigContent.ShouldContain("newVersion=\"40.0.0.0\"");

File.GetLastWriteTime(outputAppConfigFile).ShouldBeGreaterThan(oldTimestamp);
File.GetCreationTime(outputAppConfigFile).ShouldBe(oldTimestamp, TimeSpan.FromSeconds(5));
File.GetLastWriteTime(outputAppConfigFile).ShouldBe(oldTimestamp, TimeSpan.FromSeconds(5));
}

private BindingRedirectsExecutionResult GenerateBindingRedirects(string appConfigFile, string targetAppConfigFile,
Expand Down
9 changes: 1 addition & 8 deletions src/Tasks/AssemblyDependency/GenerateBindingRedirects.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Licensed to the .NET Foundation under one or more agreements.
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
Expand Down Expand Up @@ -139,13 +139,6 @@ public override bool Execute()
doc.Save(stream);
}
}
else if (outputExists)
{
// if the file exists and the content is up to date, then touch the output file.
var now = DateTime.Now;
File.SetLastAccessTime(OutputAppConfigFile.ItemSpec, now);
File.SetLastWriteTime(OutputAppConfigFile.ItemSpec, now);
}

return !Log.HasLoggedErrors;
}
Expand Down