Make cache-add APIs experimental #9330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
dfederm
reviewed
Oct 13, 2023
dfederm
reviewed
Oct 13, 2023
dfederm
reviewed
Oct 16, 2023
dfederm
reviewed
Oct 16, 2023
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
JanKrivanek
approved these changes
Oct 19, 2023
YuliiaKovalova
approved these changes
Oct 19, 2023
rainersigwald
added a commit
that referenced
this pull request
Oct 19, 2023
Make newly-added, not-yet-released cache-add API surface internal rather than public to avoid having to maintain a clunky interface for the long term. End-to-end cache plugin tests against private MSBuild from this PR and reported success.
rainersigwald
added a commit
that referenced
this pull request
Oct 19, 2023
…BindingRedirects-touch' (#9338) into vs17.8
rainersigwald
force-pushed
the
exp/privatize-cache
branch
from
cc96c1a to
b052228
Compare
rainersigwald
added a commit
to dotnet-maestro-bot/msbuild
that referenced
this pull request
Oct 25, 2023
Suppress package-compat warnings related to dotnet#9330. Co-authored-by: Mariana Dematte <[email protected]> Co-authored-by: Gang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work item (Internal use):
Summary
Make newly-added, not-yet-released cache-add API surface internal rather than public to avoid having to maintain a clunky interface for the long term.
Customer Impact
Minimal--we've talked to the only known implementer of the new APIs and they have updated based on privates to use reflection.
Long-term we will design a better, more supportable API to expose, minimizing our maintenance burden.
Regression?
No, new feature in 17.8/8.0.100.
Testing
@dfederm updated against private MSBuild from this PR and reported success.
Risk
Medium-low. Some of the code change is more complex than just moving public->internal, but it's all in new, not-widely-used API surface.