[ClickOnce] Fix publishing of content items from child projects. #9209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ning51
approved these changes
Sep 7, 2023
… child projects, include output of target that get the transitive source items from child projects
rainersigwald
approved these changes
Sep 15, 2023
John-Hart
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#1846089
Context
ClickOnce is not publishing copy-local content items from child projects.
Changes Made
GetCopyToOutputDirectoryItems target gets the content items of transitive project dependencies. The itemgroup with these contents is however getting cleared.
With this change, the content item group is being preserved and ClickOnce publishing target is now adding the TransitiveItemsToCopyToOutputDirectory itemgroup to its publish output.
Testing
Manual testing + Validation from CTI team of both customer repro and functional testing.
Notes