Adds Test target #9193
Merged
Adds Test target #9193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JanKrivanek
approved these changes
Oct 26, 2023
Member
JanKrivanek
left a comment
JanKrivanek
left a comment
There was a problem hiding this comment.
This looks ok.
Before merging it just needs explicit approval from 1ES and sdk team about the overal msbuild /test idea and its implementation.
Member
|
Is there some ETA for this one? |
MarcoRossignoli
approved these changes
Nov 6, 2023
Update target name, as requested by Test team
Evangelink
approved these changes
Nov 15, 2023
JanKrivanek
reviewed
Nov 21, 2023
YuliiaKovalova
approved these changes
Nov 21, 2023
ladipro
reviewed
Nov 21, 2023
Member
|
Closing to wake-up stuck auto-merge |
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Dec 15, 2023
This was added in dotnet#9193 but not usable in VS.
rainersigwald
added a commit
that referenced
this pull request
Dec 18, 2023
This was added in #9193 but not usable in VS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At the moment we can run tests with
dotnet /test, but the same is not true for MSBuild directly. In order to allow for such functionality, a new target is needed.Since it is possible that there exist targets with the name "Test" in the wild, this target is behind a condition, to avoid breaking users who have not opted-in.
usage:
msbuild /t:Test /p:UseMSBuildTestInfrastructure=trueChanges Made
Test