Skip to content

Switch TaskItemData exceptions #9003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Switch TaskItemData exceptions #9003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Framework/TaskItemData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public TaskItemData(ITaskItem original)
IEnumerable<KeyValuePair<string, string>> IMetadataContainer.EnumerateMetadata() => Metadata;

void IMetadataContainer.ImportMetadata(IEnumerable<KeyValuePair<string, string>> metadata)
=> throw new NotImplementedException();
=> throw new InvalidOperationException($"{nameof(TaskItemData)} does not support write operations");

public int MetadataCount => Metadata.Count;

Expand All @@ -66,7 +66,7 @@ public IDictionary CloneCustomMetadata()

public void CopyMetadataTo(ITaskItem destinationItem)
{
throw new NotImplementedException();
throw new InvalidOperationException($"{nameof(TaskItemData)} does not support write operations");
}

public string GetMetadata(string metadataName)
Expand All @@ -77,12 +77,12 @@ public string GetMetadata(string metadataName)

public void RemoveMetadata(string metadataName)
{
throw new NotImplementedException();
throw new InvalidOperationException($"{nameof(TaskItemData)} does not support write operations");
}

public void SetMetadata(string metadataName, string metadataValue)
{
throw new NotImplementedException();
throw new InvalidOperationException($"{nameof(TaskItemData)} does not support write operations");
}

public override string ToString()
Expand Down