-
Notifications
You must be signed in to change notification settings - Fork 1.4k
remove #if NEVER in hashset #8986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The Originals directory is now empty, so maybe this can be removed as well?
msbuild/src/Build/Microsoft.Build.csproj
Lines 803 to 805 in 39e20dc
<ItemGroup> | |
<Compile Remove="Collections\RetrievableEntryHashSet\Originals\*" /> | |
</ItemGroup> |
Is it still necessary to keep modified copies of BCL containers in this repo? Specifically for |
Not that I'm aware of. Note that it's a hybrid of the two- a dictionary with the storage of a HashSet, because the key is stored on the value |
fixed |
This is a modified copy of Hashset and someone circa 2008 figured it would be helpful to have the unused bits commented out (and indented) so as to easily diff the two. That turned out to be unnecessary.