-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Improve waiting for the server is in use by the signal that a marker file is created by the build task #8981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generally not a good idea to have timeouts like this, or to increase them without detailed data indicating why.
Is it possible to get a distinct signal from the second process that it's going, perhaps a line on stdout or a file that acts as a marker?
…file is created by the build task.
Thanks for the suggestion! It's possible to let the build task create a marker file as the signal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks so much better!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It now looks much more solid then the original test - thanks!
Fixes #8956
Context
#8956 (comment)
Changes Made
Improve waiting for the server is in use by the signal that a marker file is created by the build task.
Testing
Notes