Skip to content

Add unit test for https://github.com/dotnet/msbuild/pull/8870 #8961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2023
Merged

Add unit test for https://github.com/dotnet/msbuild/pull/8870 #8961

merged 5 commits into from
Jul 28, 2023

Conversation

@JaynieBai
Copy link
Member

@JaynieBai JaynieBai commented Jun 27, 2023 •
edited
Loading

Fixes 8939

Context

#8870 (comment)

Changes Made

Add a task that returns a custom ITaskItem implementation that has a custom IDictionary type returned from CloneCustomMetadata()
Add unit test TestTaskDictionaryOutputItems()

@JaynieBai JaynieBai marked this pull request as ready for review June 28, 2023 05:51
JanKrivanek
JanKrivanek suggested changes Jun 29, 2023
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks as a good starting point.
I believe we need to add custom IDictionary implementation and verification of the resulting task output in order to test the fix

@JaynieBai
Copy link
Member Author

JaynieBai commented Jul 3, 2023

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 3, 2023

Azure Pipelines successfully started running 1 pipeline(s).

@JaynieBai JaynieBai requested a review from JanKrivanek July 18, 2023 08:58
rainersigwald
rainersigwald approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I believe addresses @JanKrivanek's concerns.

JanKrivanek
JanKrivanek approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JaynieBai JaynieBai merged commit 6c1bb22 into main Jul 28, 2023
@JaynieBai JaynieBai deleted the jennybai/issue8939 branch July 28, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rainersigwald rainersigwald rainersigwald approved these changes

+1 more reviewer

@JanKrivanek JanKrivanek JanKrivanek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Explicit unit test for KeyValuePair<string, string> metadata

4 participants

@JaynieBai @rainersigwald @JanKrivanek