Skip to content

Fix /warnaserror false positive overall success #8953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix /warnaserror false positive overall success #8953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/Build/BackEnd/BuildManager/BuildManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2466,7 +2466,6 @@ private void CheckForActiveNodesAndCleanUpSubmissions()
// shut down.
submission.CompleteLogging();

_overallBuildSuccess = _overallBuildSuccess && (submission.BuildResult.OverallResult == BuildResultCode.Success);
CheckSubmissionCompletenessAndRemove(submission);
}

Expand All @@ -2480,7 +2479,6 @@ private void CheckForActiveNodesAndCleanUpSubmissions()

submission.CompleteResults(new GraphBuildResult(submission.SubmissionId, new BuildAbortedException()));

_overallBuildSuccess &= submission.BuildResult.OverallResult == BuildResultCode.Success;
CheckSubmissionCompletenessAndRemove(submission);
}

Expand Down Expand Up @@ -2592,8 +2590,6 @@ private void ReportResultsToSubmission(BuildResult result)

submission.CompleteResults(result);

_overallBuildSuccess = _overallBuildSuccess && (_buildSubmissions[result.SubmissionId].BuildResult.OverallResult == BuildResultCode.Success);

CheckSubmissionCompletenessAndRemove(submission);
}
}
Expand All @@ -2611,8 +2607,6 @@ private void ReportResultsToSubmission(GraphBuildResult result)
{
submission.CompleteResults(result);

_overallBuildSuccess &= submission.BuildResult.OverallResult == BuildResultCode.Success;

CheckSubmissionCompletenessAndRemove(submission);
}
}
Expand All @@ -2628,6 +2622,7 @@ private void CheckSubmissionCompletenessAndRemove(BuildSubmission submission)
// If the submission has completed or never started, remove it.
if (submission.IsCompleted || submission.BuildRequest == null)
{
_overallBuildSuccess &= (submission.BuildResult?.OverallResult == BuildResultCode.Success);
_buildSubmissions.Remove(submission.SubmissionId);

// Clear all cached SDKs for the submission
Expand All @@ -2648,6 +2643,7 @@ private void CheckSubmissionCompletenessAndRemove(GraphBuildSubmission submissio
// If the submission has completed or never started, remove it.
if (submission.IsCompleted || !submission.IsStarted)
{
_overallBuildSuccess &= submission.BuildResult?.OverallResult == BuildResultCode.Success;
_graphBuildSubmissions.Remove(submission.SubmissionId);

// Clear all cached SDKs for the submission
Expand Down