use InvariantCulture with double.TryParse #8853
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this need a change wave as it may break builds? Btw usually it's best to keep large formatting changes in their own PR if possible |
|
The change is also in PR #8710 which is in a change wave.
The editor auto-format on save with remove trailing space was enabled and I missed it. The changes are all whitespace at the end of a line. I'll make a commit to undo the whitespace change |
|
The formatting changes have been reverted. |
|
PR #8710 contains all the changes that are in this PR. |
Yes. |
|
Thank you @jrdodds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8798
Context
Locale differences can produce different results
Changes Made
Change to use overloads of double.TryParse() that accept an IFormatProvider
Testing
ran unit test suite
Notes