Do not require msbuild.exe.config on .NET Core #883
Conversation
All of the code that could read configuration data out of msbuild.exe.config is dependent on System.Configuration, which isn't available in .NET Core. The reading code was all #if'ed out, but we still required that the file be physically present, or MSBuild would fail on initialization. I made `IsValidMSBuildPath` dependent on the same compile-time check as src/Shared/ToolsetElement.cs.
rainersigwald
force-pushed
the
core-exe-config
branch
from
e027297 to
dafd4fe
Compare
|
@AndyGerlicher does this look reasonable to you? I thought we were still reading toolsets on Core but we clearly weren't because all the toolset-reading code is not built. We shouldn't require an auxiliary file that we don't need . . . |
|
|
|
@dotnet-bot test OSX Build for CoreCLR please |
|
@rainersigwald, @AndyGerlicher, that OSX build break http://dotnet-ci.cloudapp.net/job/Microsoft_msbuild/job/_OSX_CoreCLR_prtest/86/ was same as #676 (http://dotnet-ci.cloudapp.net/job/Microsoft_msbuild/job/_OSX_CoreCLR_prtest/89/). This probably is intermittent issue, but is there a tracking issue for this or should we have one? It might be the issue with CoreCLR etc. but it probably needs more investigation. :) |
ghost
mentioned this pull request
|
is there a nupkg we can reference? |
|
@piotrpMSFT I kicked off a build, will let you know the version when it's done. |
|
@piotrpMSFT |
All of the code that could read configuration data out of
msbuild.exe.config is dependent on System.Configuration, which isn't
available in .NET Core. The reading code was all #if'ed out, but we still
required that the file be physically present, or MSBuild would fail on
initialization.
I made
IsValidMSBuildPathdependent on the same compile-time check assrc/Shared/ToolsetElement.cs.