Customize opt-in for CG step #8691
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
wtgodbe
requested changes
Apr 21, 2023
Member
wtgodbe
left a comment
wtgodbe
left a comment
There was a problem hiding this comment.
Other than the one change, looks good
Member
|
Make sure to port this to all of your |
wtgodbe
approved these changes
Apr 21, 2023
Member
Author
|
Superseded by #8695 (that will eventually flow back to main) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Explict call to
ComponentGovernanceComponentDetection@0task (via/eng/common/templates/steps/component-governance.ymltemplate) based on the branch name (so that this can be invoked for 'vs*' branches as well)Note
This will be breaking until we consume this arcade update: dotnet/arcade@b1a9b86, it's now flowing to MSBuild main in this PR: #8658
Testing the changes on: https://github.com/dotnet/msbuild/tree/vs-test-only
ADO run: (vs* branch, the CG step injected) https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=7672204&view=logs&j=bb592630-4b9d-53ad-3960-d954a70a95cf&t=424211a8-7b86-5e93-500e-ae39b50be1a7