Skip to content

Conversation

@heng-liu
Copy link
Contributor

@heng-liu heng-liu commented Apr 1, 2023

Related to a new feature (consuming pdbs/documents from packages), which was brought in in .NET 7.
PR from sdk: dotnet/sdk#27580

Document the CopyDebugSymbolFilesFromPackages and CopyDocumentationFilesFromPackages properties.

@heng-liu
Copy link
Contributor Author

heng-liu commented Apr 1, 2023

//cc @baronfel

Copy link
Member

@JanKrivanek JanKrivanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Do we want to document those on learn portal?
I see those are already documented: https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#copydebugsymbolfilesfrompackages All good then

@heng-liu
Copy link
Contributor Author

heng-liu commented Apr 6, 2023

Thanks for reviewing @JanKrivanek!
Seems I'm not authorized to merge this PR.. Could you help merge this PR? Thanks!
Or, is there anything else blocking the merging? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants