Prefer sln-defined platforms for command-line builds over dynamic platform resolution #8589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks good to me. Potentially outside the scope of this PR but I do wonder if it makes sense to warn devs building slns with dynamicplatformresolution turned on that behavior will be different in slns vs non slns |
MIchaelRShea
approved these changes
Mar 27, 2023
rainersigwald
approved these changes
Mar 28, 2023
Forgind
approved these changes
Mar 28, 2023
Member
|
Passed on a similar baseline earlier, and all legs except macOS are passing now--but macOS hasn't gotten a machine for 30+ minutes. I'm going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer sln-defined platforms for command-line builds over dynamic platform resolution
Today dynamic platform resolution is inconsistent due to the condition being based on
$(BuildingInsideVisualStudio), which is obviously only set in VS. Sln-based command-line builds wouldn't have that set though, so dynamic platform resolution would end up running. The comment on_GetProjectReferencePlatformPropertiesimplies that sln-provided platforms should be used instead though, so this change switches the condition to check$(CurrentSolutionConfigurationContents)instead to make the experience consistent when building a sln in VS or command-line.