Exclude isolation-violating cache results from output results cache (#4386) #8257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyShepelev
changed the title
Forgind
approved these changes
Dec 27, 2022
DmitriyShepelev
force-pushed
the
exclude-isolation-violating-cache-results-from-orc
branch
from
e243133 to
5813a27
Compare
DmitriyShepelev
force-pushed
the
exclude-isolation-violating-cache-results-from-orc
branch
from
5813a27 to
abbd63c
Compare
rainersigwald
approved these changes
Jan 9, 2023
Forgind
added
the
merge-when-branch-open
JaynieBai
pushed a commit
that referenced
this pull request
Apr 19, 2023
Update documentation given the merge of #8249, #8257, and #8330. --------- Co-authored-by: Rainer Sigwald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4386
Context
Any cache entries from projects excluded from isolation constraints should be excluded from the output results cache file.
Changes Made
Only the cache entry with the smallest configuration ID (that of the project to be built in isolation) should be serialized into the output results cache file. As described in #4386, this prevents the case where dependency projects pass down the same cache entry obtained through skipping/violating isolation constraints to a dependent project, creating duplicate input cache entries.
Testing
Added a UT.
Notes
Addressing this issue since it came up frequently when testing #8249.