Skip to content

Drop the net35 asset from the StringTools package #8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaynieBai merged 4 commits into from
Nov 30, 2022
Merged

Drop the net35 asset from the StringTools package #8198

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0cc6d9
Drop the net35 asset from the StringTools package
ViktorHofer Nov 28, 2022
69dfef9
Update StringTools.csproj
ViktorHofer Nov 29, 2022
b0f9075
Update StringTools.csproj
ViktorHofer Nov 29, 2022
be64037
Update StringTools.csproj
ViktorHofer Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/StringTools/StringTools.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFrameworks>$(LibraryTargetFrameworks)</TargetFrameworks>
<TargetFrameworks Condition="'$(MSBuildRuntimeType)' != 'Core' and '$(MonoBuild)' != 'true'">$(LibraryTargetFrameworks);net35</TargetFrameworks>
<TargetFrameworks>$(LibraryTargetFrameworks);net35</TargetFrameworks>
<PlatformTarget>AnyCPU</PlatformTarget>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<IsPackable>true</IsPackable>
Expand All @@ -14,6 +13,11 @@

<AssemblyName>Microsoft.NET.StringTools</AssemblyName>
<PackageDescription>This package contains the $(AssemblyName) assembly which implements common string-related functionality such as weak interning.</PackageDescription>

<IncludeBuildOutput Condition="'$(TargetFramework)' == 'net35'">false</IncludeBuildOutput>
<!-- Don't publish the reference assembly if the build output isn't included. -->
<TargetsForTfmSpecificBuildOutput Condition="'$(IncludeBuildOutput)' != 'true'" />
Comment thread
ViktorHofer marked this conversation as resolved.
Outdated
<NoWarn Condition="'$(IncludeBuildOutput)' != 'true'">$(NoWarn),NU5128</NoWarn>
</PropertyGroup>

<PropertyGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
Expand Down