Skip to content

Fix arguments passing to MSBuild Server #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rokonec merged 8 commits into from
Jun 21, 2022
Merged

Fix arguments passing to MSBuild Server #7723

rokonec merged 8 commits into from
Jun 21, 2022

Conversation

@rokonec
Copy link
Member

@rokonec rokonec commented Jun 21, 2022

Context

We were joining dotnet "string[] args" into string, but there were issues with escaping spaces and such in file paths.

Changes Made

After analyze we have realized that best way is to pass command line as string[] to dotnet MSBuild Server.
This generate problems with readability due to few #ifdef but without extensive refactoring there is no way around. If this pose issue in future we can refactor this. I would recommend IMultiPlatformCommandLine layer with two implementations.

Testing

Manual.

rokonec and others added 8 commits May 31, 2022 10:12
@rokonec
Solving memory leak by reusing BuildManager and ProjectRoolElementCache
8080b4c
@rokonec
Do not clear project root element cache if in auto reload.
e41cf8a
@rokonec @Forgind
Reduce if
447225c 
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
@rokonec
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
c2691b1 
…build into feature/msbuild-server
@rokonec
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
60179f8 
…build into feature/msbuild-server
@rokonec
Send command line as string[] in dotnet builds.
5670086
@rokonec
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
c994838 
…build into feature/msbuild-server
@rokonec
Merge branch 'feature/msbuild-server' into rokonec/msbuild-server/fix…
1800fc0 
…-arguments-passing

# Conflicts:
#	src/Build/BackEnd/Node/ServerNodeBuildCommand.cs
@rokonec rokonec changed the title Rokonec/msbuild server/fix arguments passing Fix arguments passing to MSBuild Server Jun 21, 2022
@rokonec rokonec requested a review from AR-May June 21, 2022 14:17
@rokonec rokonec mentioned this pull request Jun 21, 2022
Closed
AR-May
AR-May approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokonec rokonec merged commit dec0fbc into dotnet:feature/msbuild-server Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AR-May AR-May AR-May approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rokonec @AR-May