Skip to content

Conversation

@rokonec
Copy link
Member

@rokonec rokonec commented Jun 14, 2022

Context

Some unit tests was flaky as there is race condition caused by client disconnecting (closing pipe) faster than server does.

Changes Made

Let endpoint knows client could disconnect and gracefully recover from it.

Testing

Manual.
Repeating CI pipeline run.

@rokonec
Copy link
Member Author

rokonec commented Jun 14, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Member Author

rokonec commented Jun 14, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Member Author

rokonec commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec rokonec requested a review from AR-May June 15, 2022 07:48
@rokonec
Copy link
Member Author

rokonec commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec
Copy link
Member Author

rokonec commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rokonec
Copy link
Member Author

rokonec commented Jun 16, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rokonec rokonec merged commit 4b42b69 into dotnet:feature/msbuild-server Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants