Moving some public types to Experimental namespace #7688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d.Experimental" namespace.
Forgind
approved these changes
Jun 8, 2022
Contributor
Forgind
left a comment
Forgind
left a comment
There was a problem hiding this comment.
I'm curious if it'd be better to move some of these APIs to internal rather than experimental, but I think this is fine.
On the other hand, first flaky failure of MSBuildServerTest? I'm not feeling great about that...
AR-May
approved these changes
Jun 9, 2022
Member
AR-May
left a comment
AR-May
left a comment
There was a problem hiding this comment.
This change looks good.
I wonder, why don't we use the new attribute for the experimental in parallel with the namespace change. We would need ifdefs to turn it on only for .net core msbuild. It could be in this PR, or we might create one more for this change.
Member
|
Decided not to use the new attribute to make testing of MSBuild server feature easier and separate two different stories: MSBuild server and experimental attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7684