Skip to content
Merged
Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
b0a788d
[WIP-FEATURE] MSBuild server node (#7489)
MichalPavlik Apr 21, 2022
3c24e9a
Removed IHanshake interface and removed duplicate code from ServerNod…
MichalPavlik Apr 25, 2022
3be5f95
[WIP-FEATURE] MSBuild client (#7540)
AR-May Apr 28, 2022
cdacf78
Change server mutex name generationt to support posix
rokonec May 3, 2022
e0a7bc8
Fix appending FORCECONSOLECOLOR log parametr
rokonec May 9, 2022
f97f022
Server instrumentation (#7602)
Forgind May 16, 2022
5c2eead
Added cancelation feature (#7638)
MichalPavlik May 24, 2022
5ade626
Fix control sequence emission (#7630)
Forgind May 30, 2022
8080b4c
Solving memory leak by reusing BuildManager and ProjectRoolElementCache
rokonec May 27, 2022
e41cf8a
Do not clear project root element cache if in auto reload.
rokonec May 27, 2022
447225c
Reduce if
rokonec May 27, 2022
836f6ef
Solving memory leak by reusing BuildManager and ProjectRoolElementCac…
rokonec Jun 2, 2022
88f571c
Put msbuild server feature under ChangeWave 17.4. (#7661)
AR-May Jun 2, 2022
88f3410
Add support for MSBUILDDEBUGONSTART env. var. for msbuild server clie…
AR-May Jun 2, 2022
b4a3482
Fix msbuild server process launch. (#7673)
AR-May Jun 6, 2022
206f918
Add test for MSBuild Server (#7592)
Forgind Jun 7, 2022
c2691b1
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
rokonec Jun 7, 2022
90d6f32
Added cancelation support for client. (#7659)
MichalPavlik Jun 7, 2022
4b42b69
Fix graceful disconnection (#7701)
rokonec Jun 16, 2022
39a56d0
Moving public types not intended to use externally to "Microsoft.Buil…
MichalPavlik Jun 16, 2022
60179f8
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
rokonec Jun 20, 2022
1c9ed27
Propagete Console properties to MSBuild Server (#7683)
rokonec Jun 20, 2022
c994838
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
rokonec Jun 21, 2022
dec0fbc
Fix arguments passing to MSBuild Server (#7723)
rokonec Jun 21, 2022
324efc5
Merge branch 'main' into feature/msbuild-server
AR-May Jun 23, 2022
b92eeef
Fix wrong merge.
AR-May Jun 23, 2022
8d2ea0f
Make logging asynchronous
AR-May Jun 24, 2022
8904e83
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
rokonec Jun 24, 2022
981a7bd
Update src/Build/BackEnd/Client/MSBuildClient.cs
MichalPavlik Jun 28, 2022
93c62a3
MSBuild Server: Always run MSBuild nodes with MSBUILDUSESERVER disabl…
AR-May Jun 28, 2022
8032e69
Fix copyright info. (#7758)
AR-May Jun 29, 2022
200fbb9
Fixed some commented issues (#7759)
MichalPavlik Jun 30, 2022
23fb4a6
Update doc (#7740)
MichalPavlik Jul 1, 2022
a55907e
Merge branch 'main' into feature/msbuild-server
AR-May Jul 1, 2022
7a293b2
Added argument null checking
rokonec Jul 11, 2022
c9a1e61
Delete dead commented code
rokonec Jul 11, 2022
072b447
Delete dead code
rokonec Jul 11, 2022
265f3b7
prefix mutexes name by msbuild
rokonec Jul 11, 2022
2aa65ba
Reuse ConnectToPipeStream from NodeProviderOutOfProcBase
rokonec Jul 11, 2022
ca8f983
Merge branch 'feature/msbuild-server' of https://github.com/dotnet/ms…
rokonec Jul 11, 2022
e45470a
Merge branch 'main' of https://github.com/dotnet/msbuild into feature…
rokonec Jul 11, 2022
504f720
Unshipped api fix
rokonec Jul 11, 2022
c625fc1
Reduces allocations in case the tracing is not enabled (#7814)
MichalPavlik Jul 12, 2022
6d00e2b
Fix msbuild client exit type for connection errors. (#7816)
AR-May Jul 12, 2022
26b43b0
Emmit BuildTelemetry event (#7778)
rokonec Jul 12, 2022
60abe1f
Increase console refresh to 25Hz
rokonec Jul 12, 2022
ae46347
Do not recover from TrySendBuildCommand failure
rokonec Jul 13, 2022
9c2f0f3
Move *ConcoleConfiguration classes to its own files
rokonec Jul 13, 2022
aa17a3f
Change test timing
rokonec Jul 13, 2022
b87a5be
Add comment for graph build telemetry project
rokonec Jul 13, 2022
568e61f
Fix English in comment
rokonec Jul 13, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions documentation/specs/event-source.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ EventSource is primarily used to profile code. For MSBuild specifically, a major
| GenerateResourceOverall | Uses resource APIs to transform resource files into strongly-typed resource classes. |
| LoadDocument | Loads an XMLDocumentWithLocation from a path.
| MSBuildExe | Executes MSBuild from the command line. |
| MSBuildServerBuild | Executes a build from the MSBuildServer node. |
| PacketReadSize | Reports the size of a packet sent between nodes. Note that this does not include time information. |
| Parse | Parses an XML document into a ProjectRootElement. |
| ProjectGraphConstruction | Constructs a dependency graph among projects. |
Expand Down
1 change: 1 addition & 0 deletions documentation/wiki/ChangeWaves.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ A wave of features is set to "rotate out" (i.e. become standard functionality) t
### 17.4
- [Respect deps.json when loading assemblies](https://github.com/dotnet/msbuild/pull/7520)
- [Remove opt in for new schema for CombineTargetFrameworkInfoProperties](https://github.com/dotnet/msbuild/pull/6928)
- [MSBuild server](https://github.com/dotnet/msbuild/pull/7634)

### 17.0
- [Scheduler should honor BuildParameters.DisableInprocNode](https://github.com/dotnet/msbuild/pull/6400)
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<Import Project="..\Shared\FileSystemSources.proj" />
<Import Project="..\Shared\DebuggingSources.proj" />
Expand Down Expand Up @@ -78,8 +78,8 @@
<Compile Include="..\Shared\UnitTests\TestData\GlobbingTestData.cs">
<Link>TestData\GlobbingTestData.cs</Link>
</Compile>
<Compile Include="..\Shared\ProcessExtensions.cs" />
<Compile Include="..\UnitTests.Shared\RunnerUtilities.cs" />

<None Include="..\Shared\UnitTests\App.config">
<Link>App.config</Link>
<SubType>Designer</SubType>
Expand Down
4 changes: 1 addition & 3 deletions src/Build.OM.UnitTests/NugetRestoreTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@
#endif
using Xunit.Abstractions;

#nullable disable

namespace Microsoft.Build.Engine.OM.UnitTests
{
public sealed class NugetRestoreTests
Expand All @@ -29,7 +27,7 @@ public NugetRestoreTests(ITestOutputHelper output)
[Fact]
public void TestOldNuget()
{
string msbuildExePath = Path.GetDirectoryName(RunnerUtilities.PathToCurrentlyRunningMsBuildExe);
string msbuildExePath = Path.GetDirectoryName(RunnerUtilities.PathToCurrentlyRunningMsBuildExe)!;
using TestEnvironment testEnvironment = TestEnvironment.Create();
TransientTestFolder folder = testEnvironment.CreateFolder(createFolder: true);
// The content of the solution isn't known to matter, but having a custom solution makes it easier to add requirements should they become evident.
Expand Down
29 changes: 29 additions & 0 deletions src/Build.UnitTests/BackEnd/RedirectConsoleWriter_Tests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Licensed to the .NET Foundation under one or more agreements.
Comment thread
AR-May marked this conversation as resolved.
Outdated
// The .NET Foundation licenses this file to you under the MIT license.
//

using System;
using System.Text;
using System.Threading.Tasks;
using Microsoft.Build.Experimental;
using Xunit;

namespace Microsoft.Build.Engine.UnitTests.BackEnd
{
public class RedirectConsoleWriter_Tests
Comment thread
rokonec marked this conversation as resolved.
{
[Fact]
public async Task EmitConsoleMessages()
Comment thread
rokonec marked this conversation as resolved.
{
StringBuilder sb = new StringBuilder();
var writer = OutOfProcServerNode.RedirectConsoleWriter.Create(text => sb.Append(text));

writer.WriteLine("Line 1");
await Task.Delay(300);
Comment thread
rokonec marked this conversation as resolved.
Outdated
writer.Write("Line 2");
writer.Dispose();
Comment thread
MichalPavlik marked this conversation as resolved.
Outdated

Assert.Equal($"Line 1{Environment.NewLine}Line 2", sb.ToString());
Comment thread
MichalPavlik marked this conversation as resolved.
Outdated
}
}
}
Loading