Skip to content

Conversation

@Forgind
Copy link
Contributor

@Forgind Forgind commented May 16, 2022

Context

When building with the MSBuild server, you could sometimes see VT100 control character sequences rather than interpreting them as desired. This fixes that.

Changes Made

Tell the console to expect VT100.

Testing

Built before and after; it displayed properly with this change.

Copy link
Member

@AR-May AR-May left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label May 17, 2022
@danmoseley
Copy link
Member

Does this work on Windows 7?

@Forgind
Copy link
Contributor Author

Forgind commented May 19, 2022

Does this work on Windows 7?

I don't know nearly enough about the differences between windows 7 and windows 11 to have a clue. Is there some reason we should expect it to fail? I can spin up a VM to test if you'd like.

@danmoseley
Copy link
Member

Is there some reason we should expect it to fail?

simply that there was considerable investment since Windows 7 in better supporting standard terminal output. I have zero context on this particular API but it struck me that it could have been affected.

@rainersigwald rainersigwald removed the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label May 24, 2022
Copy link
Member

@rainersigwald rainersigwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the win7 question is a good one that needs to be thought through. It may introduce a limitation on the MSBuild Server stuff (but I don't think it's worth a huge amount of effort: I wouldn't be too sad if the answer was "disable MSBuild server on Win7").

@Forgind
Copy link
Contributor Author

Forgind commented May 26, 2022

I spun up a windows 7 VM and overwrote the MSBuild assemblies in the 6.0.300 SDK with assemblies from this build. When I tried building in cmd.exe, output with MSBUILDUSESERVER=1 or undefined looked the same. However, it took several seconds to start up when MSBUILDUSESERVER was enabled—not entirely sure why. In any case, I think this works properly on windows 7, but it seems like maybe people using windows 7 will want to opt out anyway.

@rokonec rokonec merged commit 5ade626 into dotnet:feature/msbuild-server May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants