Skip to content

SA1509 Opening braces should not be preceded by blank line #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2022
Merged

SA1509 Opening braces should not be preceded by blank line #7274

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae409e9
SA1509 Opening braces should not be preceded by blank line
elachlan Jan 12, 2022
694db95
Remove braces and additional refactor
elachlan Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ dotnet_diagnostic.SA1507.severity = suggestion
dotnet_diagnostic.SA1508.severity = suggestion

# Opening braces should not be preceded by blank line
dotnet_diagnostic.SA1509.severity = suggestion
dotnet_diagnostic.SA1509.severity = warning

# 'else' statement should not be preceded by a blank line
dotnet_diagnostic.SA1510.severity = suggestion
Expand Down
1 change: 0 additions & 1 deletion src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3338,7 +3338,6 @@ public void UpdateAndRemoveShouldUseCaseInsensitiveMatching()
public static IEnumerable<Object[]> UpdateAndRemoveShouldWorkWithEscapedCharactersTestData
{
get

{
var expectedMetadata = new[]
{
Expand Down
1 change: 0 additions & 1 deletion src/Build/Utilities/EngineFileUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ internal static string[] GetFileListUnescaped
string directoryEscaped,
string filespecEscaped
)

{
return GetFileList(directoryEscaped, filespecEscaped, returnEscaped: false, forceEvaluateWildCards: false, excludeSpecsEscaped: null, fileMatcher: FileMatcher.Default);
}
Expand Down
1 change: 0 additions & 1 deletion src/MSBuild/CommandLineSwitchException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ private CommandLineSwitchException
StreamingContext context
) :
base(info, context)

{
ErrorUtilities.VerifyThrowArgumentNull(info, nameof(info));

Expand Down
1 change: 0 additions & 1 deletion src/MSBuild/InitializationException.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ private InitializationException
StreamingContext context
) :
base(info, context)

{
ErrorUtilities.VerifyThrowArgumentNull(info, nameof(info));

Expand Down
1 change: 0 additions & 1 deletion src/StringTools/StringTools.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
namespace Microsoft.NET.StringTools
{
public static class Strings

{
#region Fields

Expand Down
2 changes: 0 additions & 2 deletions src/Tasks.UnitTests/XslTransformation_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,6 @@ public void CompiledDllWithTwoTypes()
string doubleTypePath = Path.Combine(dir, "double.dll");

CompileDoubleType(doubleTypePath);

{
XslTransformation t = new XslTransformation();
t.BuildEngine = engine;
Expand Down Expand Up @@ -912,7 +911,6 @@ public void MultipleXmlInputs_Matching()
// outputPaths have one output path, lets duplicate it
TaskItem[] outputMultiPaths = new TaskItem[] { new TaskItem(outputPaths[0].ItemSpec + ".1.xml"),
new TaskItem(outputPaths[0].ItemSpec + ".2.xml"), new TaskItem(outputPaths[0].ItemSpec + ".3.xml"), new TaskItem(outputPaths[0].ItemSpec + ".4.xml") };

{
XslTransformation t = new XslTransformation();
t.BuildEngine = engine;
Expand Down