Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
Original file line number Diff line number Diff line change
Expand Up @@ -996,7 +996,7 @@ dotnet_diagnostic.SA1507.severity = suggestion
dotnet_diagnostic.SA1508.severity = suggestion

# Opening braces should not be preceded by blank line
dotnet_diagnostic.SA1509.severity = suggestion
dotnet_diagnostic.SA1509.severity = warning

# 'else' statement should not be preceded by a blank line
dotnet_diagnostic.SA1510.severity = suggestion
Expand Down
1 change: 0 additions & 1 deletion src/Build.OM.UnitTests/Definition/ProjectItem_Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3338,7 +3338,6 @@ public void UpdateAndRemoveShouldUseCaseInsensitiveMatching()
public static IEnumerable<Object[]> UpdateAndRemoveShouldWorkWithEscapedCharactersTestData
{
get

{
var expectedMetadata = new[]
{
Expand Down
1 change: 0 additions & 1 deletion src/Build/Utilities/EngineFileUtilities.cs
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ internal static string[] GetFileListUnescaped
string directoryEscaped,
string filespecEscaped
)

{
return GetFileList(directoryEscaped, filespecEscaped, returnEscaped: false, forceEvaluateWildCards: false, excludeSpecsEscaped: null, fileMatcher: FileMatcher.Default);
}
Expand Down
1 change: 0 additions & 1 deletion src/MSBuild/CommandLineSwitchException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ private CommandLineSwitchException
StreamingContext context
) :
base(info, context)

{
ErrorUtilities.VerifyThrowArgumentNull(info, nameof(info));

Expand Down
1 change: 0 additions & 1 deletion src/MSBuild/InitializationException.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ private InitializationException
StreamingContext context
) :
base(info, context)

{
ErrorUtilities.VerifyThrowArgumentNull(info, nameof(info));

Expand Down
1 change: 0 additions & 1 deletion src/StringTools/StringTools.cs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
namespace Microsoft.NET.StringTools
{
public static class Strings

{
#region Fields

Expand Down
33 changes: 16 additions & 17 deletions src/Tasks.UnitTests/XslTransformation_Tests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -865,25 +865,25 @@ public void CompiledDllWithTwoTypes()

CompileDoubleType(doubleTypePath);

XslTransformation t = new()
{
XslTransformation t = new XslTransformation();
t.BuildEngine = engine;
t.OutputPaths = outputPaths;
t.XmlContent = _xmlDocument;
t.XslCompiledDllPath = new TaskItem(doubleTypePath);
try
{
t.Execute();
Console.WriteLine(engine.Log);
}
catch (Exception e)
{
Assert.Contains("error?", e.Message);
}

System.Diagnostics.Debug.WriteLine(engine.Log);
BuildEngine = engine,
OutputPaths = outputPaths,
XmlContent = _xmlDocument,
XslCompiledDllPath = new TaskItem(doubleTypePath),
};
try
{
t.Execute();
Console.WriteLine(engine.Log);
}
catch (Exception e)
{
Assert.Contains("error?", e.Message);
}

System.Diagnostics.Debug.WriteLine(engine.Log);

CleanUp(dir);
}
#endif
Expand Down Expand Up @@ -912,7 +912,6 @@ public void MultipleXmlInputs_Matching()
// outputPaths have one output path, lets duplicate it
TaskItem[] outputMultiPaths = new TaskItem[] { new TaskItem(outputPaths[0].ItemSpec + ".1.xml"),
new TaskItem(outputPaths[0].ItemSpec + ".2.xml"), new TaskItem(outputPaths[0].ItemSpec + ".3.xml"), new TaskItem(outputPaths[0].ItemSpec + ".4.xml") };

{
XslTransformation t = new XslTransformation();
t.BuildEngine = engine;
Expand Down