Skip to content

SA1408 Conditional expressions should declare precedence #7269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022
Merged

SA1408 Conditional expressions should declare precedence #7269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -956,7 +956,7 @@ dotnet_diagnostic.SA1405.severity = suggestion
dotnet_diagnostic.SA1407.severity = suggestion

# Conditional expressions should declare precedence
dotnet_diagnostic.SA1408.severity = suggestion
dotnet_diagnostic.SA1408.severity = warning

dotnet_diagnostic.SA1410.severity = none

Expand Down
2 changes: 1 addition & 1 deletion src/Build/BackEnd/BuildManager/BuildManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -909,7 +909,7 @@ public void EndBuild()
{
// Override the build success if the user specified /warnaserror and any errors were logged outside of a build submission.
if (exceptionsThrownInEndBuild ||
_overallBuildSuccess && loggingService.HasBuildSubmissionLoggedErrors(BuildEventContext.InvalidSubmissionId))
(_overallBuildSuccess && loggingService.HasBuildSubmissionLoggedErrors(BuildEventContext.InvalidSubmissionId)))
{
_overallBuildSuccess = false;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Build/BackEnd/Components/ProjectCache/ProjectCacheService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public void PostCacheRequest(CacheRequest cacheRequest)

ErrorUtilities.VerifyThrowInternalError(
LateInitializationForVSWorkaroundCompleted is null ||
_projectCacheDescriptor.VsWorkaround && LateInitializationForVSWorkaroundCompleted.Task.IsCompleted,
(_projectCacheDescriptor.VsWorkaround && LateInitializationForVSWorkaroundCompleted.Task.IsCompleted),
"Completion source should be null when this is not the VS workaround");

BuildRequestData buildRequest = new BuildRequestData(
Expand Down Expand Up @@ -314,7 +314,7 @@ static bool IsDesignTimeBuild(ProjectInstance project)
var buildingProject = project.GlobalPropertiesDictionary[DesignTimeProperties.BuildingProject]?.EvaluatedValue;

return MSBuildStringIsTrue(designTimeBuild) ||
buildingProject != null && !MSBuildStringIsTrue(buildingProject);
(buildingProject != null && !MSBuildStringIsTrue(buildingProject));
}

void EvaluateProjectIfNecessary(CacheRequest request)
Expand Down