Skip to content

SA1134 Each attribute should be placed on its own line of code #7263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2022
Merged

SA1134 Each attribute should be placed on its own line of code #7263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cef379f
SA1134 Each attribute should be placed on its own line of code
elachlan Jan 12, 2022
72cccb4
Fixes from code review
elachlan Jan 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ dotnet_diagnostic.SA1132.severity = warning
dotnet_diagnostic.SA1133.severity = suggestion

# Each attribute should be placed on its own line of code
dotnet_diagnostic.SA1134.severity = suggestion
dotnet_diagnostic.SA1134.severity = warning

# Using directive should be qualified
dotnet_diagnostic.SA1135.severity = suggestion
Expand Down
8 changes: 6 additions & 2 deletions src/MSBuildTaskHost/Concurrent/ConcurrentQueue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,12 +549,16 @@ internal struct Slot
}
}
}

/// <summary>Padded head and tail indices, to avoid false sharing between producers and consumers.</summary>
[DebuggerDisplay("Head = {Head}, Tail = {Tail}")]
[StructLayout(LayoutKind.Explicit, Size = 192)] // padding before/between/after fields based on typical cache line size of 64
internal struct PaddedHeadAndTail
{
[FieldOffset(64)] public int Head;
[FieldOffset(128)] public int Tail;
[FieldOffset(64)]
public int Head;

[FieldOffset(128)]
public int Tail;
}
}