Skip to content

SA1006 A C# preprocessor-type keyword is preceded by space. #7200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SA1006 A C# preprocessor-type keyword is preceded by space. #7200

wants to merge 1 commit into from

Conversation

@elachlan
Copy link
Contributor

@elachlan elachlan commented Jan 2, 2022

@elachlan elachlan mentioned this pull request Jan 2, 2022
Open
sharwell
sharwell approved these changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Consider increasing SA1006 to warning as part of this pull request

@Forgind
Copy link
Contributor

Forgind commented Jan 3, 2022

💡 Consider increasing SA1006 to warning as part of this pull request

I was assuming all this would happen with rebasing on #7192, right?

@elachlan
Copy link
Contributor Author

elachlan commented Jan 3, 2022

💡 Consider increasing SA1006 to warning as part of this pull request

I was assuming all this would happen with rebasing on #7192, right?

Yes, pretty much. That would be ideal.

@elachlan
Copy link
Contributor Author

elachlan commented Jan 3, 2022

Only changes are to deprecated code. Closing PR.

@elachlan elachlan closed this Jan 3, 2022
@elachlan elachlan deleted the SA1006 branch January 8, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sharwell sharwell sharwell approved these changes

@Forgind Forgind Forgind approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@elachlan @Forgind @sharwell