Skip to content

Convert CodeAnalysis.ruleset to .globalconfig #7192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 7, 2022
Merged

Convert CodeAnalysis.ruleset to .globalconfig #7192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
79748da
Convert CodeAnalysis.ruleset to .editorconfig
elachlan Dec 30, 2021
a9aeaf7
convert ruleset to globalconfig
elachlan Dec 31, 2021
ec10d5f
changed based on suggestions in PR
elachlan Dec 31, 2021
6566afb
Fix the Analyzers so they actually work
elachlan Dec 31, 2021
922a961
Set dotnet_diagnostic.AD0001.severity = warning
elachlan Dec 31, 2021
0eff5d0
update StyleCop
elachlan Dec 31, 2021
9101e88
canonical casing of the prop name is EnableNETAnalyzers
elachlan Jan 3, 2022
5d52a95
disable code analyzers on deprecated projects
elachlan Jan 3, 2022
ed3ce87
disable code analyzers on deprecated projects
elachlan Jan 3, 2022
0dc8f2e
Different .globalconfig for test projects
elachlan Jan 3, 2022
f4f32a6
Fix white space on Packages.props
elachlan Jan 3, 2022
9408c9d
Changes from code review
elachlan Jan 3, 2022
1e91653
Apply suggestions from code review
elachlan Jan 7, 2022
4ff55aa
Use SDK Analyzer
elachlan Jan 7, 2022
12841f3
Only list differences in Common.Test.globalconfig
elachlan Jan 7, 2022
0e2968c
Apply suggestions from code review
elachlan Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,10 @@

<DisableImplicitNuGetFallbackFolder>true</DisableImplicitNuGetFallbackFolder>
</PropertyGroup>

<Import Project="$(RepositoryEngineeringDir)Analyzers.props" />

<!-- Enable SDK supplied netanalyzers for all target frameworks -->
<PropertyGroup>
<EnableAnalyzers>true</EnableAnalyzers>
<EnableNETAnalyzers>true</EnableNETAnalyzers>
</PropertyGroup>

</Project>
12 changes: 12 additions & 0 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,18 @@
<None Include="$(ThirdPartyNotice)" Pack="true" PackagePath="notices" Visible="false" Condition=" '$(IsPackable)' == 'true' " />
</ItemGroup>

<!-- Global Analyzer Config -->
<ItemGroup Condition="'$(ProjectIsDeprecated)' != 'true'">
<!-- Include Common.globalconfig for non-deprecated projects-->
<EditorConfigFiles Include="$(MSBuildThisFileDirectory)eng/Common.globalconfig" />
</ItemGroup>

<!-- Test Project Global Analyzer Config -->
<ItemGroup Condition="'$(IsTestProject)' == 'true'">
<!-- Include Common.Test.globalconfig for Test projects-->
<EditorConfigFiles Include="$(MSBuildThisFileDirectory)eng/Common.Test.globalconfig" />
</ItemGroup>

<PropertyGroup>
<CentralPackagesFile>$(MSBuildThisFileDirectory)eng/Packages.props</CentralPackagesFile>
</PropertyGroup>
Expand Down
7 changes: 0 additions & 7 deletions eng/Analyzers.props
View file
Open in desktop

This file was deleted.

389 changes: 0 additions & 389 deletions eng/CodeAnalysis.ruleset
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions eng/Common.Test.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Top level entry required to mark this as a global AnalyzerConfig file
is_global = true

# Element parameter documentation should have text
dotnet_diagnostic.SA1614.severity = none
Loading