Skip to content

Set CA1507 to Warning and fix instances of errors #7176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2022
Merged

Set CA1507 to Warning and fix instances of errors #7176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a33a90
Set CA1507 to Warning and fix instances of errors
elachlan Dec 29, 2021
24f66c8
Revert ruleset changes
elachlan Jan 7, 2022
50eca21
Merge branch 'dotnet:main' into CA1507
elachlan Jan 7, 2022
fac5937
Change CA1507 to warning
elachlan Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Common.globalconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ dotnet_diagnostic.CA1505.severity = none
dotnet_diagnostic.CA1506.severity = none

# Use nameof to express symbol names
dotnet_diagnostic.CA1507.severity = suggestion
dotnet_diagnostic.CA1507.severity = warning

# Avoid dead conditional code
dotnet_diagnostic.CA1508.severity = none
Expand Down
4 changes: 2 additions & 2 deletions src/Shared/ToolsetElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public string toolsVersion
{
get
{
return (string)base["toolsVersion"];
return (string)base[nameof(toolsVersion)];
}

set
Expand Down Expand Up @@ -740,7 +740,7 @@ public string DefaultOverrideToolsVersion
// whenever the base class gives us an empty string.
// Note this means we can't distinguish between the attribute being present but containing
// an empty string for its value and the attribute not being present at all.
string defaultValue = (string)base["DefaultOverrideToolsVersion"];
string defaultValue = (string)base[nameof(DefaultOverrideToolsVersion)];
return String.IsNullOrEmpty(defaultValue) ? null : defaultValue;
}

Expand Down