-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adjust Indentation in XAML Rules and Common props/targets/tasks #7168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Indentation in XAML Rules and Common props/targets/tasks #7168
Conversation
|
As you can see, some source files have also been touched. They belong to a different set of patches but I have extracted whitespace changes early on. |
|
The PR #7165 removes the logic related to compatibility with MSBuild v4 and Dev11/Dev12. If that is approved, much of the changes here wouldn't apply. So, please wait until there's a verdict on that PR! And I'll rebase the PR accordingly. |
Forgind
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
7dc9239 to
1d1c988
Compare
|
All done. Updated in response to #7165! |
1d1c988 to
e175fc8
Compare
|
Updated in response to #7169! |
e175fc8 to
50b74ae
Compare
|
@Nirmal4G were these changes made via VS or some tool? The diff is massive, but if I can review each commit knowing it was done by automation it'd be easier to glance through instead of parsing every change. Side note: this should merge as 1 commit |
|
@benvillalobos Only 2nd commit (not all lines) were done by me, manually.
You'll lose the clean diff, if not rebased. Anyway, it's just my suggestion.
|
These are the files that would be touched by VS Editor later. Separating the whitespace changes early on would help reviewers.
Remove EOF New Lines Remove Unnecessary New Lines Add New Lines between code/comment blocks This is done separately to ensure that the diff for the actual changes would be as clean as possible.
Follow 2-space indent everywhere For Multi-line comments, text starting between comment tags should be 4-space and extra 2-space for the text that follows from the previous line. This is done separately to ensure that the diff for the actual changes would be as clean as possible.
50b74ae to
5648271
Compare
Part of #4779
Context
Make Common props, targets and tasks easier to read and understand.
Make Visual Studio's Property Page (XAML) Rules easier to read and understand.
Part of the larger refactoring that'll lead into #1686
Changes Made
Notes
I'll also make sure not to mess up the git blame too much.
To make reviewing easier, I had split up the changes logically rather than a file.
The commits by themselves are logical changes. So, if possible, rebase merge them to preserve file history view in Git.
Also, please do note that these changes won't make much difference alone but with other formatting and refactors that follow this will make a world of difference in reading these files.