Use cached StringBuilder in CreateManifestResourceName #7012
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5551
Context
Addressing a small inefficiency pointed out in #5551. If the task is given multiple resource files it wastefully creates a new
StringBuilderfor each.Changes Made
Reuse a cached
StringBuilderwhen creating resource names.Testing
Existing unit tests.
Notes
StringBuilderis not used "append-only" so this is not a good fit forSpanBasedStringBuilder.StringBuilderis not a big deal with very minor perf impact compared to the exception handling machinery.