Check if Documentis null before creating elementlocation object #6998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rokonec
requested changes
Oct 28, 2021
yuehuang010
changed the title
rokonec
approved these changes
Oct 29, 2021
benvillalobos
approved these changes
Oct 29, 2021
Forgind
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When ownerDocumentWithLocation.FullPath is null, then ElementLocation is always created. This is because ElementLocation.Empty.File is " " (empty not null).
This can occurs when a project is created from memory or loaded from a stream which loses all file information.
Changes Made
Add null check.
Testing
Standard unittest
Notes