-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Spurious Windows test failure in FindOnPathSucceeds #6975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cceeds() at ToolTask_Tests.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. This worked for me -- my main computer passed all tests for the first time in a long time!
Just one nitpick in your implementation.
|
comments resolved and tested locally. @rainersigwald |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
|
Hi. I added one small change as well, for linux and macOS unit tests to pass. Can you please approve that as well for CI if possible? @rainersigwald |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldly supports case-insensitive comparison so I think this could also be:
cmdPath.ShouldBe(expectedCmdPath, Case.Insensitive);in the Windows branch (with expectedCmdPath being the one path on Windows). Looks great with ToUpperInvariant() as well, thank you!
oh..thats actually much better...i'll watch out for that..thanks! |
Fixes #6869
Context
cmd.exefull path retrieval from PATH environment variable and comparison in unit test was case sensitive.Changes Made
Converted
cmd.exefull path to lowercase to repair case sensitivity for flaky unit test factFindOnPathSucceeds()atToolTask_Tests.csTesting
Debugging, unit test run and code compiling.
Notes