Expander shortcut for string.LastIndexOfAny() #6963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing a string as a char array to call string.LastIndexOfAny(char[]) seems like a sensible thing to do. However the other two overloads expecting a startIndex and count seem to be too exotic to support.
ladipro
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
I'm honestly not even sure how to pass a char array to a function in MSBuild, and I saw people using strings, so I guess makes sense to support that?
IndexOfAny is already supported, implemented exactly the way you implemented LastIndexOfAny so I'd say this makes perfect sense. Thank you!
rainersigwald
approved these changes
Oct 15, 2021
rainersigwald
added
the
merge-when-branch-open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing a string as a char array to call string.LastIndexOfAny(char[]) seems like a sensible thing to do.
However the other two overloads expecting a
startIndex and count seem to be too exotic to support.
I'm honestly not even sure how to pass a char array to a function in MSBuild, and I saw people using strings, so I guess makes sense to support that?